search

rostam / GraphTea

The Graph Theory Software
http://graphtheorysoftware.com/
85 stars 28 forks source link

Create MaxCut.java #26

Closed ghost closed 10 years ago

ghost commented 10 years ago

Hi. I added the maximum cut algorithm for undirected graph (local search method) to the Algorithms section.

azinazadi commented 10 years ago

Hey Dear Mostafa,

This looks very good. but it fits more to be a report than an algorithm. An algorithm in GraphTea is usually meant to show the steps of what's happening to the user and have more an educational use. a Report is meant to calculate a metric of the graph and report the result.

it would be nice if you convert it to a report extension. That should be very easy for you. if you need help I can help you also. please let me know.

best, azin

ghost commented 10 years ago

Dear Azin,

I deleted max cut algorithm. It is converted to report extension.

Thanks, Mostafa Shaeri

ghost commented 10 years ago

Regarding to issue #14 , I have changed the code in UndoManager, UndoAction and RedoAction. Now it saves graph state directly in GraphModel format.

azinazadi commented 10 years ago

Dear @mostafashaeritj , I check the code for the undo/redo and I didnt get the point of saving the graph model, as the graph model doesnt change if you just take the instance of it. it will be always the same unless you make a new graph model. but by adding a vertex for example, the graph model will be the same. So Did you check the undo functionality after changing this code? I guess it should get broken.

it would be nice to make seperate pull request for the undo/redo and the report so first I bring your perfect report into the GraphTea. for the undo/redo we should dig more into it.

thx, Azin