rostools / r-cubed-intermediate

Reproducible Research in R: An Intermediate Workshop on Modern Approaches and Workflows to Processing Data
https://r-cubed-intermediate.rostools.org/
Other
5 stars 4 forks source link

Use .groups = "drop" instead of dplyr::ungroup() #47

Closed AndersAskeland closed 4 months ago

AndersAskeland commented 4 months ago

Would it be better to ungroup data when using summarise using the .groups argument?

It could perhaps be preferred to not do it, as the argument is experimental. However, maybe update text to note that they almost do the same thing (identical if only using grouping for summarise).

AndersAskeland commented 4 months ago

This was also remove the message about grouping without having to set any options.

lwjohnst86 commented 4 months ago

Hmm, good point. Let's do that!