rotary-genomics / rotary

Assembly/annotation workflow for Nanopore-based microbial genome data containing circular DNA elements
BSD 3-Clause "New" or "Revised" License
2 stars 1 forks source link

Fix coverage summary #126

Closed jmtsuji closed 7 months ago

jmtsuji commented 7 months ago

Fixes a couple intertwined issues in rule summarize_contigs_by_coverage that caused errors when running rotary in long read only mode, to address one part of #118

In the previous version of rotary, long-read only mode actually worked with rule summarize_contigs_by_coverage, but only when a coverage filter threshold was supplied in the config file. The rule resulted in an error when no long read coverage filter thresholds were supplied (which is the config default) in long-read only mode.

In this update, the following changes were made to address this problem:

Because of how rule summarize_contigs_by_coverage was moved into an existing conditional block in polish.smk, the git diff does not show the file changes very cleanly -- my apologies!

In the long term, I think it might make sense to move the code in summarize_contigs_by_coverage into a Python utility script -- this would make it easier to write/run tests on some of the logic being performed in this code.

Let me know if you have any thoughts -- thanks!

LeeBergstrand commented 7 months ago

In the long term, I think it might make sense to move the code in summarize_contigs_by_coverage into a Python utility script -- this would make it easier to write/run tests on some of the logic being performed in this code.

@jmtsuji This sounds good. Feel free to create an issue for this.

jmtsuji commented 7 months ago

In the long term, I think it might make sense to move the code in summarize_contigs_by_coverage into a Python utility script -- this would make it easier to write/run tests on some of the logic being performed in this code.

@jmtsuji This sounds good. Feel free to create an issue for this.

Will include in issue #120

LeeBergstrand commented 7 months ago

@jmtsuji Looks good to me at a glance. Feel free to merge in.