rotary-genomics / rotary

Assembly/annotation workflow for Nanopore-based microbial genome data containing circular DNA elements
BSD 3-Clause "New" or "Revised" License
3 stars 1 forks source link

Fix snakemake version to be less than 8.6.0 to fix temp delete issue. #216

Closed LeeBergstrand closed 2 months ago

LeeBergstrand commented 2 months ago

Snakemake 8.6.0 introduced a bug that prevented the deletion of temp files created before a checkpoint, even after a complete DAG execution. This bug was introduced when a pull request was merged into version 8.6.0 of Snakemake, which prevented some corner cases where temp files were deleted before a checkpoint even though they were needed later. However, this change prevents any temp files before a checkpoint from being deleted. After this bug was introduced, these temp files were not deleted, even at the end of the pipeline. We have many gigabytes of temp files in our pipeline before the checkpoint 'split_circular_and_linear_contigs' that need to be deleted; this leads to my server running out of storage room. I provided a bug report to Snakemake here: https://github.com/snakemake/snakemake/issues/2982

As a temporary fix I am fixing the Snakemake version to be less than 8.6.0 but more than 8.0.0.

LeeBergstrand commented 2 months ago

I figured out that I basically have to go back farther to version 7.0 because older versions of snakemake 8 are not stable and cause issues.