search

rotary-genomics / rotary

Assembly/annotation workflow for Nanopore-based microbial genome data containing circular DNA elements
BSD 3-Clause "New" or "Revised" License
2 stars 1 forks source link

Fix GTDB-Tk install error #88

Closed jmtsuji closed 9 months ago

jmtsuji commented 9 months ago

Fixes #87 via proposed solution 2

jmtsuji commented 9 months ago

@LeeBergstrand After thinking about it, I lean toward the 2nd solution I proposed in issue #87. In case it's helpful, I went ahead and made a PR with this proposed solution. Feel free to provide your comments or to close this PR if you feel a different approach would be better. Thanks!

jmtsuji commented 9 months ago

This fix passes for rule validate_gtdb. I haven't yet tested it for rule run_gtdbtk, but the updated syntax should work the same way for both rules (a test is running now).

LeeBergstrand commented 9 months ago

@jmtsuji I did a little editing of the spacing in run gtdbtk. But overall, it looks good. merging.

jmtsuji commented 9 months ago

Great, thanks!