rotdrop / nextcloud-app-files-archive

Archive inspection and extraction as Nextcloud app.
Other
9 stars 4 forks source link

Compatibility mit Nextcloud 25 #10

Closed cetcondor closed 1 year ago

cetcondor commented 1 year ago

Thanks for your great work! Please make the app officially compatible with Nextcloud 25.

rotdrop commented 1 year ago

Did you try if it works? If yes you could just fork and submit a pull-request, please!

bedlamzd commented 1 year ago

on my instance I'm not able to even install it, get the following

Which seems logical, there is no 1.0.5 release at all

Error log ```shell [settings] Error: GuzzleHttp\Exception\ClientException: Client error: `GET https://github.com/rotdrop/nextcloud-app-files-archive/releases/download/v1.0.5/files_archive.tar.gz` resulted in a `404 Not Found` response: Not Found at <> 0. /var/www/html/3rdparty/guzzlehttp/guzzle/src/Middleware.php line 69 GuzzleHttp\Exception\RequestException::create(GuzzleHttp\Psr7\Request {}, "*** sensitive parameters replaced ***", null, [], null) 1. /var/www/html/3rdparty/guzzlehttp/promises/src/Promise.php line 204 GuzzleHttp\Middleware::GuzzleHttp\{closure}("*** sensitive parameters replaced ***") 2. /var/www/html/3rdparty/guzzlehttp/promises/src/Promise.php line 153 GuzzleHttp\Promise\Promise::callHandler(1, "*** sensitive parameters replaced ***", null) 3. /var/www/html/3rdparty/guzzlehttp/promises/src/TaskQueue.php line 48 GuzzleHttp\Promise\Promise::GuzzleHttp\Promise\{closure}("*** sensitive parameters replaced ***") 4. /var/www/html/3rdparty/guzzlehttp/promises/src/Promise.php line 248 GuzzleHttp\Promise\TaskQueue->run(true) 5. /var/www/html/3rdparty/guzzlehttp/promises/src/Promise.php line 224 GuzzleHttp\Promise\Promise->invokeWaitFn() 6. /var/www/html/3rdparty/guzzlehttp/promises/src/Promise.php line 269 GuzzleHttp\Promise\Promise->waitIfPending() 7. /var/www/html/3rdparty/guzzlehttp/promises/src/Promise.php line 226 GuzzleHttp\Promise\Promise->invokeWaitList() 8. /var/www/html/3rdparty/guzzlehttp/promises/src/Promise.php line 62 GuzzleHttp\Promise\Promise->waitIfPending() 9. /var/www/html/3rdparty/guzzlehttp/guzzle/src/Client.php line 187 GuzzleHttp\Promise\Promise->wait() 10. /var/www/html/lib/private/Http/Client/Client.php line 218 GuzzleHttp\Client->request("get", "https://github. ... z", ["/var/www/html/ ... "]) 11. /var/www/html/lib/private/Installer.php line 295 OC\Http\Client\Client->get("https://github. ... z", ["/tmp/oc_tmp_f0U2Pg-.tar.gz",120]) 12. /var/www/html/apps/settings/lib/Controller/AppSettingsController.php line 448 OC\Installer->downloadApp("files_archive") 13. /var/www/html/lib/private/AppFramework/Http/Dispatcher.php line 225 OCA\Settings\Controller\AppSettingsController->enableApps(["files_archive"], []) 14. /var/www/html/lib/private/AppFramework/Http/Dispatcher.php line 133 OC\AppFramework\Http\Dispatcher->executeController(OCA\Settings\Con ... {}, "enableApps") 15. /var/www/html/lib/private/AppFramework/App.php line 172 OC\AppFramework\Http\Dispatcher->dispatch(OCA\Settings\Con ... {}, "enableApps") 16. /var/www/html/lib/private/Route/Router.php line 298 OC\AppFramework\App::main("OCA\\Settings\\ ... r", "enableApps", OC\AppFramework\ ... {}, ["settings.AppSettings.enableApps"]) 17. /var/www/html/lib/base.php line 1047 OC\Route\Router->match("/settings/apps/enable") 18. /var/www/html/index.php line 36 OC::handleRequest() POST /settings/apps/enable from 77.222.27.60 by kvatch at 2022-11-16T19:44:20+00:00 ```

UPD dug up a bit deeper. There is a 1.0.5 tag but anyway no files_archive.tar.gz with it

Please, make a new release with files

rotdrop commented 1 year ago

The release was broken (see #9) and there does not seem to be a way to remove releases from the Nextcloud app-store (please FIXME if I am wrong). The cureent pre-release has been confirmed to fix #9 and will now be released as a new version.

rotdrop commented 1 year ago

on my instance I'm not able to even install it, get the following

Which seems logical, there is no 1.0.5 release at all

Could you please avoid posting off-topic? Please file a new issue for a new problem, thank you!

rotdrop commented 1 year ago

There are new feature branches for pdf_downloader and files_archive which address this problem. In principle things seem to just work.

You could try to install just the latest release and test them ...

p-bo commented 1 year ago

Just referencing there too: https://github.com/rotdrop/nextcloud-app-pdf-downloader/issues/5#issuecomment-1331698437

rotdrop commented 1 year ago

Closing this now. The apps pdf_downloader and files_archive seem to work up to NC 25, for the moment you just have to edit appinfo/info.xml or force enable the app in the admin settings.