search

rotdrop / nextcloud-app-files-archive

Archive inspection and extraction as Nextcloud app.
Other
9 stars 4 forks source link

App icon invisible when using dark theme #20

Closed ae5960e8-a6fc-491f-b252-898ecf59af95 closed 1 year ago

ae5960e8-a6fc-491f-b252-898ecf59af95 commented 1 year ago

The app icon present in the menu where the app is triggered does not respect the theme setting of the user, making it invisible. I suggest changing this to the icon which is in the screenshot beside the option "Move or copy" as they are mostly identical.

image

rotdrop commented 1 year ago

The app icon present in the menu where the app is triggered does not respect the theme setting of the user, making it invisible. I suggest changing this to the icon which is in the screenshot beside the option "Move or copy" as they are mostly identical.

This is a matter of applying a suitable color transformation to the icon. There are recommendations for this but I forget where. An example is in here

https://github.com/rotdrop/nextcloud-app-files-archive/blob/b1f7b59805c9866187a77f5b40d69503dde6f576/src/PersonalSettings.vue#L185-L190

and

https://github.com/rotdrop/nextcloud-app-files-archive/blob/b1f7b59805c9866187a77f5b40d69503dde6f576/src/PersonalSettings.vue#L204-L208

I fix this eventually, thanks for reporting.

Claus

rotdrop commented 1 year ago

This should be fixed in the current release, can you please check, that this is the case?

Thank you!

ae5960e8-a6fc-491f-b252-898ecf59af95 commented 1 year ago

Fixed in latest version, thanks. :)