search

rotdrop / nextcloud-app-files-archive

Archive inspection and extraction as Nextcloud app.
Other
9 stars 4 forks source link

NC26 #24

Closed Aonodensetsu closed 11 months ago

Aonodensetsu commented 1 year ago

Add support for Nextcloud version 26, please.

rotdrop commented 1 year ago

Hi, in order to support the support for NC26, could you please try whether the app in principle works? I think the administrator can enable unsupported apps, otherwise please just edit appinfo/info.xml. Thank you for your help!

Of course, eventually as time permits I will support NC26 in this and my other apps.

Aonodensetsu commented 1 year ago

My NC broke with the major update (caused by Passwords app) so I'm currently trying to get the NC team to fix that issue, will try to revisit when time permits.

stmichalke commented 1 year ago

NC 26.0.0.11 doesn't work with files_archive 1.1.3-rc1 enabled because:

"url":"/apps/files/","message":"Declaration of OCA\FilesArchive\Storage\ArchiveStorage::filesize($path) must be compatible with OC\Files\Storage\Common::filesize($path): int|float|false

stmichalke commented 1 year ago

The app works fine with « filesize($path): int|float|false » in files_archive/lib/Storage/ArchiveStorage.php, line 307.

I'd like to thank you for your app, BTW. It's very useful.

stmichalke commented 1 year ago

FYI, with commit 10ab6da02691343220c1fec3a47e5703ea4e1a9f applied the app works with NC27 too.

rotdrop commented 11 months ago

Should be solved by https://github.com/rotdrop/nextcloud-app-files-archive/releases/tag/v1.1.3