search

rotdrop / nextcloud-app-files-archive

Archive inspection and extraction as Nextcloud app.
Other
9 stars 4 forks source link

fix(i18n): Fixed placeholder #32

Closed rakekniven closed 5 months ago

rakekniven commented 5 months ago

Removed blank.

Reported at Transifex.

rotdrop commented 5 months ago

Thanks!

rakekniven commented 5 months ago

Please backport because faulty string is still present at Transifex.

rakekniven commented 5 months ago

/backport stable27

rotdrop commented 5 months ago

I am sorry, did I miss something? That string is not there in the branch stable27

Point here is that I am currently only working on main, where stable28 is just a copy of main with compiled assets (in the hope that -- if someone wants to try it out -- a mere git clone of stable28 will suffice to get it running.

I see now that there are translation strings below 10n/ which do not correspond to any translation template present in the source code for stable27. This is of course in no means critical. However: is there something that I could have handled in a -- say -- more conforming way? Such that your "/backport stable27" would not have been necessary?

I am willing to learn ;)

rakekniven commented 5 months ago

Hey, to be honest I did not check the 27 branch.

Normally the supported versions of NC are synced next to main. That means main, stable28, stable27 and and stable26 are needed to be adapted for such changes like mine.

rakekniven commented 5 months ago

I am willing to learn ;)

Me too

rotdrop commented 5 months ago

Hi there,

Am 08.02.24 um 22:40 schrieb rakekniven:

Hey, to be honest I did not check the 27 branch.

Normally the supported versions of NC are synced next to main. That means main, stable28, stable27 and and stable26 are needed to be adapted for such changes like mine.

the point is here: the API changes from pre-28 to 28 are really extensive. In order to reflect the API changes I had to rewrite major parts of the code -- I also do not plan to backport those changes to stable26 and stable27 because many things present in NC 28 are just not there in pre-28.

Therefore stable26 and stable27 will probably just remain at their respective current state, due to lack of personal resources and because it just does not make sense in several places -- I do not see a point in emulating the NC28 APIs for NC27 and NC26. Progressing from pre-28 to 28 is a breaking change.

Kind thanks for the feed-back. Concerning the translations: I think that I did sync the main branch with stable28, and that the offending string were not present in stable26 and stable27. The offending strings should consequently no longer be there on TX, if not, please feel free to contact me again.

I really appreciate the TX service from the NC corporation (I am sure that it is not for free for the NC corporation) and of course will try -- as time permits -- to keep things as clean as possible.

Kind thanks, best regards

Claus

— Reply to this email directly, view it on GitHub https://github.com/rotdrop/nextcloud-app-files-archive/pull/32#issuecomment-1934976249, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALM54PM2YKBOEFZYHKZCPDYSVA4JAVCNFSM6AAAAABCTEI44CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZUHE3TMMRUHE. You are receiving this because you modified the open/close state.Message ID: @.***>

-- Claus-Justus Heine @.*** http://www.claus-justus-heine.de/

Schatzmeister der Camerata Academica Freiburg e.V. --- www.cafev.de