NC28 fix PHP deprecation for dynamic properties ($userId)

rotdrop / nextcloud-app-files-archive

Archive inspection and extraction as Nextcloud app.

Other

9 stars 4 forks source link

NC28 fix PHP deprecation for dynamic properties ($userId) #33

Closed rtm-ctrlz closed 3 months ago

rtm-ctrlz commented 3 months ago

This change should fix error

Creation of dynamic property OCA\FilesArchive\Service\NotificationService::$userId is deprecated at /var/www/html/custom_apps/files_archive/lib/Service/NotificationService.php#55

property $userId isn't really used by NotificationService class.

rotdrop commented 3 months ago

Thanks, you're right, $this->userId is actually unused.

rotdrop commented 3 months ago

Ok, actually this should better have been a PR against master (you could not know, of course)