rotdrop / nextcloud-app-files-archive

Archive inspection and extraction as Nextcloud app.
Other
9 stars 4 forks source link

Unable to copy folders to another folder, from a mounted .zip file #38

Closed dimangelid closed 4 months ago

dimangelid commented 5 months ago

Hello,

I have installed version 1.2.3 of the application.

My Nextcloud is at version 28.0.4 . It is hosted at a KVM Virtual Machine with Almalinux 8 and the below software versions:

PHP: 8.1.27 MariaDB: 10.6.17 Apache: 2.4.37

My PHP has the below modules enabled:

apcu
bcmath
bz2
calendar
Core
ctype
curl
date
dom
exif
fileinfo
filter
ftp
gd
gettext
gmp
hash
iconv
igbinary
imagick
intl
json
ldap
libxml
mbstring
msgpack
mysqli
mysqlnd
openssl
pcntl
pcre
PDO
pdo_mysql
pdo_sqlite
Phar
posix
rar
readline
redis
Reflection
session
shmop
SimpleXML
sockets
sodium
SPL
sqlite3
standard
sysvmsg
sysvsem
sysvshm
tokenizer
xml
xmlreader
xmlwriter
xsl
Zend OPcache
zip
zlib

When i mount a .zip file, i can view its contents without issues. I can also copy files from this mount to another folder of my Nextcloud.

When i attempt to copy folders from a mounted .zip to another folder of my Nextcloud, the folders get created at the other folders but their contents are not being moved.

During this procedure, the logs of Apache, MariaDB and my Operating System, do not record anything wrong.

Can you please check my report?

dimangelid commented 5 months ago

Hello @rotdrop ,

Did you have a chance to investigate my report?

Best Regards, Dimitris Angelidis

rotdrop commented 4 months ago

Sorry for not coming back earlier. I believe that the commit b579c84 fixes the issue. There is a brief explanation in the commit message.

dimangelid commented 4 months ago

Hello @rotdrop ,

I installed version v1.2.4-rc1 of the application at my Nextcloud.

However the issue has not been resolved.

My Nextcloud version is 28.0.4 .

Can you please check again for a possible solution?

rotdrop commented 4 months ago

Can you please send me the relevant parts from you nextcloud log file? Thanks.

rotdrop commented 4 months ago

Can you please send me the relevant parts from you nextcloud log file? Thanks.

Could you perhaps also please provide a test archive that is not working on your side, and report about your setting "strip common directory prefix", the latter because I had the impression that this was broken. But of course your problem could be different.

rotdrop commented 4 months ago

Sad story. Yesterday I had the impression that it succeeded once. More later over the weekend, of course, this should just work out of the box. Unfortunately, there is hardly any error in the log files, safe something from the files_versions app -- but this seems to appear later.

rotdrop commented 4 months ago

Sad story. Yesterday I had the impression that it succeeded once. More later over the weekend, of course, this should just work out of the box. Unfortunately, there is hardly any error in the log files, safe something from the files_versions app -- but this seems to appear later.

So the state of the affair is

Still to test (just to be sure): recursive copying out of other external mounts

No clue at the moment, there are no error messages -- and the view in the frontend is correct. Of course, this should just work. I will also investigate how the files_external app handles copying. One suspicion would be that "recursiveness" has to be implemented by the storage (this app). But I do not think so.

rotdrop commented 4 months ago

... it does work with NC27 with the old version of the app. Maybe this gives some hints to track it down. However, this has to wait a bit, plan is to resolve the issue this weekend.

rotdrop commented 4 months ago

Fixed in 3d2ef287f52a4f26aefb88d7e3d9ec6dd0c49f6e -- opendir() needs to return a resource, not an array of files.

rotdrop commented 4 months ago

Do you have a chance to test whether it now also works for you? Kind thanks!

rotdrop commented 4 months ago

I believe that this issue could be closed ...

dimangelid commented 4 months ago

Hello @rotdrop ,

I just tried version v1.2.4-rc7 at my Nextcloud Enterprise 28.0.6

It worked without issues, both with .zip and .7z files.

Thank you for fixing this.

rotdrop commented 4 months ago

Nice, then we can close this issue. Thank you for reporting!