File integrity check fails - Githubissues

rotdrop / nextcloud-app-pdf-downloader

Recusively convert entire directory trees to PDF and provide the resulting document as download.

Other

3 stars 4 forks source link

File integrity check fails #2

Closed EmJotGeh closed 2 years ago

EmJotGeh commented 2 years ago

Hi,

the file integrity check fails after installation.

rotdrop commented 2 years ago

Thanks for reporting. I'll be on holiday and really offline from 24.07. - 14.08., so this issue will have to wait until then.

rotdrop commented 2 years ago

root@mailexchange.claus-justus-heine.de:/var/www/cloud/nextcloud# sudo -u www-data php ./occ integrity:check-app pdf_downloader
  - FILE_MISSING:
    - vendor/tecnickcom/tcpdf/tools/.htaccess:
      - expected: 384ad1b42cc64b0a9e82431ddc5330aa02d3f87ef874bdf5bd0ab7933661ba746a2986899f4b39343a8b598cef5b32d775a94fc889badae992dc4ece155ff89d
      - current:

OTOH, in the release tar file the .htaccess is there. So I assume that the NC installer deletes all .htaccess files? Mmmh.

rotdrop commented 2 years ago

Ok, the reason is that .htaccess is blacklisted and not installed by Nextcloud. I'll exclude it in the next release. This was a composer provided file. In principle one could also cleanup up the vendor/ directory further, but so what.

rotdrop commented 2 years ago

This should have been fixed with release v1.0.2. Would you mind to try and report back if this fixes the issue?

EmJotGeh commented 2 years ago

Thank you for this useful app. The file integrity check is now working and no longer gives an error.

rotdrop commented 2 years ago

Thanks for reporting back! Closing the issue.