Compatibility to NC 26 - Githubissues

rotdrop / nextcloud-app-pdf-downloader

Recusively convert entire directory trees to PDF and provide the resulting document as download.

Other

3 stars 4 forks source link

Compatibility to NC 26 #38

Closed raffaelone closed 1 year ago

raffaelone commented 1 year ago

Is there any news about the release of a stable version compatible with Nextcloud 26?

Thanks

rotdrop commented 1 year ago

Currently on holiday, the master branch should work, but a release will not happen before start of August.

22.07.2023 11:54:30 raffaelone @.***>:

Is there any news about the release of a stable version compatible with Nextcloud 26?

Thanks

— Reply to this email directly, view it on GitHub[https://github.com/rotdrop/nextcloud-app-pdf-downloader/issues/38], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AALM54JW57CREXWZMSFQSYTXROPNDANCNFSM6AAAAAA2TXO73M]. You are receiving this because you are subscribed to this thread.[Verfolgungsbild][https://github.com/notifications/beacon/AALM54NURXT6ZZCMFTVN6MDXROPNDA5CNFSM6AAAAAA2TXO73OWGG33NNVSW45C7OR4XAZNFJFZXG5LFVJRW63LNMVXHIX3JMTHGYSF2CI.gif]

rotdrop commented 1 year ago

There is now a new pre-release, I have used NC v27 to generate it. There are now also stableXY branches which contain compiled assets and the vendor subdirectory for v25 - v27.

Can you please test the release? Thanks!

raffaelone commented 1 year ago

I've tested v1.1.3-rc1 on NC 25. I take this error from logs but the app works perfectly.

[index] Errore: Exception: Class "wapmorgan\UnifiedArchive\Abilities" not found in file '/var/www/nextcloud/apps/pdf_downloader/vendor/wapmorgan/unified-archive/src/Drivers/Zip.php' line 56 at <<closure>>

0. /var/www/nextcloud/lib/private/AppFramework/App.php line 172
   OC\AppFramework\Http\Dispatcher->dispatch()
1. /var/www/nextcloud/lib/private/Route/Router.php line 298
   OC\AppFramework\App::main()
2. /var/www/nextcloud/lib/base.php line 1053
   OC\Route\Router->match()
3. /var/www/nextcloud/index.php line 36
   OC::handleRequest()

rotdrop commented 1 year ago

Strange. I'll have a look. Is files_archive also installed? Thinking about incompatible UnifiedArchive versions ...

rotdrop commented 1 year ago

Strange. I'll have a look. Is files_archive also installed? Thinking about incompatible UnifiedArchive versions ...

Seems that I missed some changes in the archive-file library (wapmorgan/...). Still not sure why Abilities is not found. We will see. On-the-fly decryption of archives is probably broken ATM.

rotdrop commented 1 year ago

... there will be a new pre-release this evening ;)

rotdrop commented 1 year ago

The current prerelease seems to work for NC 25 - 26. I would just label the current state as v1.1.3 and release it.

raffaelone commented 1 year ago

Installed v1.1.3-rc2. The app works fine and there are no errors in the log.

Thanks!

rotdrop commented 1 year ago

Thanks for the feedback. I will then prepare a new "stable" release this evening.

rotdrop commented 1 year ago

I have just uploaded a new release and therefore closing this issue now. In case of problems please feel free to reopen the issue (or add a new one). Thank you for using my app and for the feedback!