Parse more parts of the error messages of checker

[GoogleCodeExporter]

First of all, thanks to Jonathan Burke for making the Eclipse plug-in parse the 
error messages of javac and creating Eclipse markers out of them. My tool 
proposes fixes from the generated markers.

I needed more information about the error messages than what was in the 
markers, e.g., I needed the offset and length of each error message. To get 
this piece of information, I had to hack Jonathan's code to parse more parts of 
the error messages.

I have attached my patch, which improves the parsing of the error messages of 
Eclipse. It would be nice to have this change pushed to upstream.

In addition to better parsing of error messages, the patch comments the  
extension point org.eclipse.ui.ide.markerResolution in 
eclipse/checker-framework-eclipse-plugin/plugin.xml, because it conflicts with 
my extension point. The extension point that I commented doesn't do any actual 
work. So, it's safe to comment it.

Unfortunately, this patch is a bit noisy because my Eclipse formatter is 
different from Jonathan's. If Jonathan shares his Eclipse formatter with me (or 
commits it to the repository), I'll start using it to have consistent 
formatting.

Please review the patch and let me know if you see any problems in pushing it 
upstream.

Original issue reported on code.google.com by reprogra...@gmail.com on 5 Dec 2013 at 7:25

Attachments:

• trimmed.diff.patch

[GoogleCodeExporter]

I've assigned the issue to Jonathan.

FYI, the Eclipse code formatter to use is stored in:

checker-framework/checkers/eclipse/checker-framework-formatter.xml

Original comment by wdi...@gmail.com on 5 Dec 2013 at 7:34

[GoogleCodeExporter]

> FYI, the Eclipse code formatter to use is stored in:
>
> checker-framework/checkers/eclipse/checker-framework-formatter.xml
Great! I missed that. I'll reformat my code and submit a new patch.

Original comment by reprogra...@gmail.com on 5 Dec 2013 at 7:42

[GoogleCodeExporter]

I just tried the formatter at 
checker-framework/checkers/eclipse/checker-framework-formatter.xml. Clearly the 
Eclipse plug-ins are not using this formatter. So, changing my formatter to 
this formatter would result in more noise.

Since other parts of the repository are already using this formatter, I suggest 
that the Eclipse plug-in starts to use it, too. This would make reviewing 
future patches to the Eclipse plug-in easier.

Original comment by reprogra...@gmail.com on 5 Dec 2013 at 7:48

[GoogleCodeExporter]

Thanks for the patch.  I'll take a look.  

Original comment by jbu...@cs.washington.edu on 6 Dec 2013 at 7:40

[GoogleCodeExporter]

Jonathan,

Did you get the chance to review my patch?

Original comment by reprogra...@gmail.com on 22 Jan 2014 at 8:45

[GoogleCodeExporter]

This patch has been applied.  Thank you for your continued help.  As for 
formatting, the Eclipse plugin was originally written in a separate repository 
and the original author did not use the checker-framework-formatter.  I 
currently use Intellij for most of my editing so I had not applied this 
formatter (though I do believe there is an Eclipse formatter plugin for 
Intellij).  In the future the Eclipse plugin will be migrated to use the 
Checker Framework formatting style.

Thanks again.

Jonathan

Original comment by Jonathan...@gmail.com on 23 Jan 2014 at 9:22

• Changed state: Pushed

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

You may find this feature of IntelliJ IDEA 13 useful for porting the Eclipes 
code formatter to IntelliJ IDEA: 
http://blog.jetbrains.com/idea/2014/01/intellij-idea-13-importing-code-formatter
-settings-from-eclipse/

Original comment by reprogra...@gmail.com on 1 Feb 2014 at 5:27

[GoogleCodeExporter]

Original comment by Jonathan...@gmail.com on 7 Feb 2014 at 8:55

• Changed state: Fixed