The value of the field Export-Package in file MANIFEST.MF of the Eclipse plug-in is incorrect

[GoogleCodeExporter]

Field Export-Package of 
eclipse/checker-framework-eclipse-plugin/META-INF/MANIFEST.MF lists a few 
packages that do not exist. As a result, Eclipse reports problems of the form 
"Package X does not exist in this plug-in" in its Problems view, where X is the 
name of a package.

For example, in eclipse/checker-framework-eclipse-plugin/META-INF/MANIFEST.MF, 
"org.checkerframework.basetype" should be replaced by 
"org.checkerframework.basic".

The file eclipse/checker-framework-eclipse-plugin/.classpath is also missing 
the references to the jars at lib/checker.jar, lib/javac.jar, and lib/jdk8.jar.

For a full list of changes that I had to make to fix the above errors, please 
see my patch at 
<https://github.com/reprogrammer/universal-type-qualifier-inference/blob/666c2e7
15507a88a3f240aec436de5c8a7d6822c/patches/checker-framework.diff>.

The list of the packages in my patch may be still incomplete. Please feel free 
to add the packages that you think need to be listed in the Export-Package 
field.

Original issue reported on code.google.com by reprogra...@gmail.com on 22 Apr 2014 at 5:01

[GoogleCodeExporter]

Original comment by michael.ernst@gmail.com on 22 Apr 2014 at 11:34

• Added labels: Priority-High
• Removed labels: Priority-Medium

[GoogleCodeExporter]

Hi Mohsen,

Thanks for the patch.  I reviewed it, applied it, and tested it.  Looks great.  
It has been pushed and will appear in the next release.

Thanks for your continued help!

Jonathan

Original comment by Jonathan...@gmail.com on 22 Apr 2014 at 6:33

• Changed state: Pushed

[GoogleCodeExporter]

As I mentioned in the original report, some packages are missing from the list, 
e.g., org.checkerframework.checker.guieffect. My patch fixes only the names of 
the packages that existed in the previous version of MANIFEST.MF.

What are your criteria for deciding what packages to export? Do you intend to 
include all packages in the Export-Package field?

I don't know if Eclipse has a way of populating the Export-Package field 
automatically. It may be a good idea to write a script to generate the value of 
the Export-Package field as it is fairly long.

Thanks for taking care of this issue.

Original comment by reprogra...@gmail.com on 22 Apr 2014 at 7:29

[GoogleCodeExporter]

At the moment we don't have a documented guideline as to what this field should 
contain.  I agree with your suggestions but I need to think about what we might 
want to include as exported packages.  I have added an issue 321 to address the 
concern.

Original comment by jbu...@cs.washington.edu on 22 Apr 2014 at 8:19

[GoogleCodeExporter]

Original comment by jtha...@cs.washington.edu on 2 May 2014 at 1:11

• Changed state: Fixed