roterdam / crystalsaf

Automatically exported from code.google.com/p/crystalsaf
0 stars 0 forks source link

Code review request: enable Crystal on .class files #27

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Purpose of code changes on this branch:
- allow analyzing .class files (issue #26)
- propagate exceptions in unit tests (issue #24)

Note that problem markers don't work well on .class files: they'll be 
associated with workspace or surrounding archive.

UI changes are incomplete: Selecting .class files will work, but Crystal will 
ignore .class files contained in selected elements or in runs on all files.  
This is because the new preference for whether to include binary archives is 
currently always false.  Passing .class files (IClassFile objects) to Crystal 
programatically will work fine.

When reviewing my code changes, please focus on:
- User-visible interface changes (IRunCrystalCommand, ICrystalAnalysis)
- Code duplication (WorkspaceUtilities) that can be removed if we are confident 
this works

After the review, I'll merge this branch into:
/trunk

Original issue reported on code.google.com by kevin.bi...@gmail.com on 6 Mar 2011 at 3:41

GoogleCodeExporter commented 9 years ago
So...Why is this issue still alive? Thomas and I reviewed and entered comments 
a couple days ago....Kevin, did you get them?

Original comment by ciera.christopher on 18 Mar 2011 at 1:42

GoogleCodeExporter commented 9 years ago

Original comment by ciera.christopher on 18 Mar 2011 at 1:43

GoogleCodeExporter commented 9 years ago
Didn't get any comments. Where are they? Google doesn't show anything in this 
review task

Original comment by kevin.bi...@gmail.com on 18 Mar 2011 at 4:59

GoogleCodeExporter commented 9 years ago
Merged and committed to HEAD (updated Crystal version to 3.5.0)

Original comment by kevin.bi...@gmail.com on 15 May 2011 at 4:43