roth-michael / FoundryVTT-RestRecovery

This repository adds support for D&D 5E's Arcane/Natural Recovery within the short rest dialog, and additional short rest mechanics
Other
20 stars 17 forks source link

[BUG] Song of Rest d6 healing not applied during short rest #180

Closed DiceAndEasy closed 9 months ago

DiceAndEasy commented 9 months ago

Describe the bug If you take a short rest with a Bard of level 2 or higher and you use hit dice to recover HP, at the end of the short rest, you will notice that the d6 healing from Song of Rest is not rolled or applied. The following error message is logged into the console once the short rest ends:

image

To Reproduce Steps to reproduce the behavior:

  1. Create a Bard player character of at least 2nd level
  2. Open their character sheet
  3. Remove some HP from them
  4. Click the short rest button on the character sheet
  5. Select the amount of Hit Dice you want to use and click "Roll"
  6. Click "Finish Short Rest"
  7. Notice that the extra d6 for healing was not rolled or applied

Expected behavior After clicking "Finish Short Rest" the d6 should automatically be rolled for all affected players and be added to their HP recovery.

Screenshots Video of the issue:

https://github.com/fantasycalendar/FoundryVTT-RestRecovery/assets/86520580/3238b769-fad8-4ce2-a8e4-92437ca09f2f

Setup:

Active modules:

Additional context Running Foundry through The Forge.

Haxxer commented 9 months ago

This should be fixed in 1.5.4 - if it does not fix it, double check that the bard character is assigned to a player and that you have the "ignore inactive players" setting enabled.

DiceAndEasy commented 9 months ago

The issue is fixed and Song of Rest dice auto rolling works if the "ignore inactive players" is disabled. With it enabled, the roll did not happen.

Also the GM was not able to trigger the Song of Rest roll, only the owning player can.