roth-michael / FoundryVTT-RestRecovery

This repository adds support for D&D 5E's Arcane/Natural Recovery within the short rest dialog, and additional short rest mechanics
Other
20 stars 17 forks source link

Only Waterskins Available #210

Closed Daegybyte closed 2 months ago

Daegybyte commented 2 months ago

When I do a long rest, I can only select from the waterskins to consume

Expected behavior I should be able to add rations so that my character doesn't always get exhausted Note: I have tried experimenting with different ration counts, like changing quantity or adding charges

Screenshots

Screenshot 2024-05-19 at 9 40 23 PM

Setup:

roth-michael commented 2 months ago

Hm, I'm having trouble reproducing this. Could you send along the details tab for the Rations item?

Daegybyte commented 2 months ago

I figured out the issue. I use items exclusively from the DDB importer from Mr. Primate. I added rations from the basic SRD and your module worked great. I don't mind just using SRD rations. But I would love DDB integration. I will be reaching out to Mr. Primate as well to see if he can change how rations are imported

roth-michael commented 2 months ago

Hmm, Rest Recovery SHOULD be automatically updating consumables. Let me check if it's something on this side of things. I can reproduce, with DDBI rations.

Daegybyte commented 2 months ago

Should I still reach out to Mr. Primate, or do you think this is a thing to be handled on your end? I am a big believer that it's possible to have too many cooks in the kitchen, so to speak.

roth-michael commented 2 months ago

Give me a little to check what the criteria is for consumable conversion. If it's something I think should be handled in DDBI, I'll reach out to Mr. Primate myself. Either way, will keep this issue open until resolved and keep you updated. Thanks for bringing it to my attention!

roth-michael commented 2 months ago

Oh, alright this is an easy one. I'm just looking for items named "Rations" or "Waterskin" right now, so "Rations (1 day)" isn't being found. Will include that fix in my next update!

Daegybyte commented 2 months ago

Thank you so much! I'm happy to contribute in some small way to this awesome project of yours that makes dnd that much better for all of us. My players got super excited when I brought up making our game more resource oriented without all the hassle.