roth-michael / FoundryVTT-RestRecovery

This repository adds support for D&D 5E's Arcane/Natural Recovery within the short rest dialog, and additional short rest mechanics
Other
20 stars 17 forks source link

[BUG] Short rest setting "Hit Die roll multipier" also affects long rest #231

Closed f4hy closed 1 month ago

f4hy commented 1 month ago

Describe the bug The setting under Short Rest for "Hit Die roll multiplier" applies the multiplier to both short and long rests. Since the setting is under the short rest tab I would expect it to only affect short rests.

To Reproduce Steps to reproduce the behavior:

  1. Go to Settings for Short Rest. And on Long Rest set "Enable long rest hit dice rolls."
  2. Set the Hit Die roll multiplier setting to be "Quarter"
  3. Prompt the users for a Long Rest
  4. See the rolls only recover 0.25 the roll value.

Expected behavior I would expect the setting to only affect rolls during short rests. Maybe the setting should be under General Settings rather than Short Rest tab. Or there should be a setting for this under both Short and Long rest tabs separately.

Screenshots

2024-06-01_15-40

Setup:

Active modules:

Additional context happy to contribute a fix.

roth-michael commented 1 month ago

Yup that's a valid point. It actually affects ALL hit die rolls, even those manually done outside of a resting context. I’ll move it to general settings in the next update.