roth-michael / FoundryVTT-RestRecovery

This repository adds support for D&D 5E's Arcane/Natural Recovery within the short rest dialog, and additional short rest mechanics
Other
19 stars 18 forks source link

Long rest not recovering minimum 1 hit die #45

Closed kaelad02 closed 2 years ago

kaelad02 commented 2 years ago

Describe the bug I have a level 1 character and when they long rest, they don't recover their 1 hit die. The rules state it's supposed to recover half, rounded down, minimum 1. I don't think the minimum 1 part is being accounted for. Not sure it's always that way or because of how I have it configured:

To Reproduce Steps to reproduce the behavior:

  1. Open the module settings and modify the Long Rest settings ad described above
  2. Select a level 1 PC, reduce their HP a bit and click the Long Rest button
  3. Click on the Begin Long Rest button
  4. Roll one hit die
  5. Click the Rest button
  6. Check the chat message, mentions recovering hit points but nothing about hit dice
  7. Check the character sheet, it shows you have 0 hit dice

Expected behavior It doesn't appear to honor the minimum 1 hit dice part. I should have seen 2 hit dice available because I checked "Enable hit dice max buffer". The chat message should have mentioned recovering 1 hit die. And I should have had 1 hit die left over after the rest, visible on the character sheet.

Setup:

Active modules:

Haxxer commented 2 years ago

Does your level 1 character have two hit dice? I'm confused about this part.

kaelad02 commented 2 years ago

No, they just have one.

If I start with the one hit die, and check "Enable hit dice recovery before finishing long rest" and "Enable hit dice max buffer", then long resting should show that I have 2 available since I started with 1 and would get 1 for long resting. Even when I've used the hit die, then long rested again, I should gain 1 hit die but I'm still stuck at 0.

Haxxer commented 2 years ago

Right, I forgot about that part. I've identified the issue, and shall patch soon.

Haxxer commented 2 years ago

Fixed in 1.2.1