Laurick commented 4 months ago

1. Why?

Now the VST hasn't any errors in the api request neither some network flow. I take the 3rd option because its more powerfull and we can move that to other projects

2. How?

There is a new module for network request for twtich api and for network requests needed for addon. That module is built using a builder pattern because coolness and has a minor cache

Also there is a base for all addon errors ( see #10 )

See docs folder/files for more information

3. Related Issue

9

4. Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules

5. Tests made (if appropriate)

This PR is not tested properly ( the network module was tested but no the twtich integration )

6. Notes (if appropriate)

None

rothiotome commented 4 months ago

Looks promising, I like the idea of the wrapper and the builder pattern. Keep me updated!

rothiotome commented 3 months ago

Amazing work, thanks for the contribution :D

rothiotome / godot-very-simple-twitch

Api errors #12