feat: Join course QR code

codiini commented 1 month ago

What does this PR do?

Fixes #349

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] Chore (refactoring code, technical debt, workflow improvements)
[ ] Enhancement (small improvements)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change adds a new database migration
[ ] This change requires a documentation update

How should this be tested?

Go to a course, go to the "people" page, click on the "add button", click on the "download QR code" button and the result is the downloaded qr code.

Checklist

Required

[x] Filled out the "How to test" section in this PR
[x] Self-reviewed my own code
[ ] Commented on my code in hard-to-understand bits
[ ] Ran pnpm build
[x] Checked for warnings, there are none
[x] Removed all console.logs
[x] Merged the latest changes from main onto my branch with git pull origin main
[x] My changes don't cause any responsiveness issues

Appreciated

[x] If a UI change was made: Added a screen recording or screenshots to this PR
[ ] Updated the ClassroomIO Docs if changes were necessary

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
cio-docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 8, 2024 4:17am

vercel[bot] commented 1 month ago

@codiini is attempting to deploy a commit to the Rotimi Best's projects Team on Vercel.

A member of the Team first needs to authorize it.

github-actions[bot] commented 1 month ago

Thank you for following the naming conventions for pull request titles! 🙏

Chifez commented 1 month ago

@codiini nice job. @rotimi-best i was thinking below the title of the course instead of the course url we should have the name of the academy instead, its nicer and having the link there defeats the purpose of a QR code.

Then also for free tier users we would want to embed our classroomio logo should be at the bottom of the card something like powered by classroomio or just our logo is fine.

rotimi-best commented 1 month ago

@Chifez Great points, thanks.

@codiini Can we make 2 improvements to what you've already done.

Instead of the course link, we should have the org name. It is in $currentOrg.name
Only for free users let's show this kind of chip at the bottom of the image

codiini commented 1 month ago

@Chifez @rotimi-best , Awesome suggestions. I'll make the changes and push them in a couple of minutes

rotimi-best / classroomio