Improve the asset details page

rotki / rotki

A portfolio tracking, analytics, accounting and management application that protects your privacy

https://rotki.com

GNU Affero General Public License v3.0

2.79k stars 513 forks source link

Improve the asset details page #2289

Closed kelsos closed 2 years ago

kelsos commented 3 years ago

Problem Definition

The issue here is for brainstorming and collecting ideas for ways to improve the page.

In v1.14.0 a new basic asset details page will be added in the application. We discussed with @LefterisJP on how to improve this page.

Include coingecko/cryptocompare information about the asset (#4457)
Include some kind of price history for the asset. For example use chart data. Example: https://api.coingecko.com/api/v3/coins/aave/market_chart?vs_currency=eur&days=7&interval=daily (#4454)
Provide a more details breakdown of how the asset is distributed in an specific account. E.g. the account has a total of 100DAI that is 40 on the chain, 20 in a vault, 20 in compound and 20 in Aave. (#4455)
Serve the data from a backend api endpoint

CruiseMan commented 3 years ago

Overlapping

Screen Shot 2021-06-26 at 11 31 48 PM

LefterisJP commented 3 years ago

Hey @CruiseMan I am quite sure this is because you have edited the number of decimals points for fiat. It should normally be only 2 in which case this should not happen.

I will wait for more input from @kelsos though.

kelsos commented 3 years ago

Yes the overallaping can happen for either really big numbers or a lot of decimal characters, I will have to look at it to see if there is a way around, maybe decrease the text size a bit the more characters you have down to a hard limit..

Can you open an issue @CruiseMan since this is not the proper issue for it.

LefterisJP commented 2 years ago

@kelsos this issue no longer sounds actionable. Or do I misunderstand?

Do you have the result of brainstorming in other issues? If yes, then I guess we can close this?

kelsos commented 2 years ago

No there are no issues created we can create issues based on the points above and close this.

kelsos commented 2 years ago

I will take care of creating the sub-issues and closing it in the following days