rotki / rotki

A portfolio tracking, analytics, accounting and management application that protects your privacy
https://rotki.com
GNU Affero General Public License v3.0
2.84k stars 524 forks source link

Delete ETH2 validators tied to an ETH1 address when it is deleted #5524

Open nebolax opened 1 year ago

nebolax commented 1 year ago

Abstract

Validators deletion UX should be improved. For validators that were detected by the app by checking eth1 addresses it should be that:

  1. It should not be possible to delete these validators from "ETH2 Balances" tab. In the current implementation is possible to delete a validator, but it gets re-detected when you refresh ETH2 balances.
  2. These validators should be automatically deleted when eth1-owner address is deleted. (Open question: how to deal with situations when one validator is owned by multiple addresses that are all tracked?)

Motivation

Improve UX.

Specification

LefterisJP commented 1 year ago

As discussed this is not really possible. You can't know who owns a validator. Which breaks the entire idea behind this.

So putting this out of the release and perhaps not sure if it's even possible to do properly. Would need thinking. If not we may end up closing and reopening when we know how to approach.

What we can do is delete validators if their depositor address is deleted. But as I said this does not mean it's the owner. At the moment we detect them by deposit, so perhaps it makes sense to also add this. But it's definitely not fool-proof.