Avoid querying prices for approvals

rotki / rotki

A portfolio tracking, analytics, accounting and management application that protects your privacy

https://rotki.com

GNU Affero General Public License v3.0

2.79k stars 513 forks source link

Avoid querying prices for approvals #8043

Open yabirgb opened 3 months ago

yabirgb commented 3 months ago

At the moment we query prices for all the history events but approvals don't really need it. Same for all the informational event. In my database approvals where 13% of all the events

Task

[ ] When querying prices for history events skip informational events

obiwanpelosi commented 1 month ago

hi, is this a frontend bug ?

yabirgb commented 1 month ago

hi, is this a frontend bug ?

Hello! I've asked and the frontend doens't query the price for approvals, it is only the backend in the task before returning them https://discord.com/channels/657906918408585217/683245846070165504/1266016650147135508

Dozie2001 commented 3 weeks ago

Hello, Is this issue still up? interested in tackling it.

yabirgb commented 3 weeks ago

Hello! Sorry missed the comment. This issue afaik is still open @Dozie2001 . If I'm not mistaken with a quick look is the function get_base_entries_missing_prices the one that needs to add the extra filter and the change should have a test