search

rotki / ui-library

Rotki's vue component library
https://rotki.github.io/ui-library/
GNU Affero General Public License v3.0
4 stars 6 forks source link

Sync changes from ui-library compat and update RuiMenuSelect #211

Closed kelsos closed 7 months ago

kelsos commented 7 months ago

Closes #(issue_number)

There are a few things I need to figure out with the menu select.

codecov-commenter commented 7 months ago

Codecov Report

Attention: Patch coverage is 84.95460% with 116 lines in your changes are missing coverage. Please review.

Project coverage is 65.05%. Comparing base (9c13068) to head (e9b8b1b).

Files Patch % Lines
src/composables/dropdown-menu.ts 58.51% 56 Missing :warning:
...c/components/forms/select/RuiMenuSelect.stories.ts 0.00% 16 Missing :warning:
src/components/forms/select/RuiMenuSelect.vue 96.68% 16 Missing :warning:
src/utils/assert.ts 0.00% 11 Missing :warning:
src/components/overlays/menu/Menu.stories.ts 0.00% 10 Missing :warning:
src/components/overlays/menu/Menu.vue 90.90% 5 Missing :warning:
src/components/forms/checkbox/Checkbox.vue 88.23% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #211 +/- ## ========================================== + Coverage 64.41% 65.05% +0.64% ========================================== Files 94 95 +1 Lines 16474 16918 +444 Branches 580 613 +33 ========================================== + Hits 10611 11006 +395 - Misses 5863 5912 +49 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.