search

roto93 / react-native-neat-date-picker

An easy to use date picker for react native.
MIT License
50 stars 29 forks source link

New languages #14

Closed arkanos closed 2 years ago

arkanos commented 2 years ago

Hi @roto93 ,

I fell in love with your datepicker and actually wanted to use it on my mobile app, but I found out that it did not have the language I was looking for.

I have created this PR in order to add some more such Spanish, German, Portuguese and French.

Also changed a bit the way translations are imported (now it uses an specific JSON file for each language) which might help on adding new languages in the future.

Last but not least, as not all languages have same words and length for each, I had to tweak a bit the buttons in order to make them look good.

As an example, this is how it looked with german language before the changes:

1

And here's how it looks after:

2

I'm open to discuss, modify or even discard these changes if required.

Thanks!

PS: Looking forward for that TS version!

roto93 commented 2 years ago

Hi @arkanos, First of all, thank you for your contribution and clear explanation. 😄 It is a great update and indeed the way I manipulated languages was not be fully considered. I have tested your PR and accepted it, please check. And also thanks for remind me that the TS version is not complete 😆. I will working on it!