rotorgames / Rg.Plugins.Popup

Xamarin Forms popup plugin
MIT License
1.15k stars 337 forks source link

Page null check in RemoveAsync for IOS + New exception classes #636

Closed LuckyDucko closed 3 years ago

LuckyDucko commented 3 years ago

:sparkles: What kind of change does this PR introduce? (Bug fix, feature, docs update...)

Null Check for pages, with the addition of exception classes

:arrow_heading_down: What is the current behavior?

if page is null, it crashes the Ios app.

:new: What is the new behavior (if this is a feature change)?

It will now throw a catchable error, allowing the developer to decide what functionality they want.

:boom: Does this PR introduce a breaking change?

no

:bug: Recommendations for testing

n/a

:memo: Links to relevant issues/docs

631

:thinking: Checklist before submitting