rotorgames / Rg.Plugins.Popup

Xamarin Forms popup plugin

MIT License

1.15k stars 337 forks source link

Accessibility upgrade585 #682

Closed LuckyDucko closed 3 years ago

LuckyDucko commented 3 years ago

:sparkles: What kind of change does this PR introduce? (Bug fix, feature, docs update...)

This fixes small bugs in the accessibility workaround, when users do not overlay a second page on their main-age and instead swap them out.

:arrow_heading_down: What is the current behavior?

Currently the app will crash if there isnt 2 pages on the stack

:new: What is the new behavior (if this is a feature change)?

It no longer crashes, and it should also work with modals

:boom: Does this PR introduce a breaking change?

n/a

:bug: Recommendations for testing

go through and test the app presented in #681

:memo: Links to relevant issues/docs

681

585

:thinking: Checklist before submitting

[x] All projects build
[x] Follows style guide lines
[x] Relevant documentation was updated
[x] Rebased onto current develop

LuckyDucko commented 3 years ago

@martijn00 im going to merge this in, as it is going to be the basis for some further upgrades by another user down the track. Don't worry about releasing a nuget for this one.