IeuanWalker commented 3 years ago

:sparkles: What kind of change does this PR introduce? (Bug fix, feature, docs update...)

Bug (semi) fix

:arrow_heading_down: What is the current behavior?

Underlining page title can be read out when the popup is open

:new: What is the new behaviour (if this is a feature change)?

This sort of fixes the issue. In the demo app, the title still gets readout but only the page title is selectable whereas previously the page + page title was selectable.

Here is a vid -	Before	After
https://user-images.githubusercontent.com/6544051/126693591-00069429-4f50-4835-8400-701c963bd02d.mp4	https://user-images.githubusercontent.com/6544051/126693656-2d96e16d-9298-40b2-bbbf-1fe9451e7d72.mp4

BUT it has completely fixed the issue in the repo project attached to the linked issue. So not sure how the demo project differs from that.

@LuckyDucko sorry it's not a complete fix, but hopefully, it helps. For reference found the code in this repo - https://github.com/PureWeen/A11YTools/blob/680c223d2e52d2c07cf50ab1801de5d4450ae2c2/A11YTools/A11YTools.Android/AccessiblePageRenderer.cs#L42

:boom: Does this PR introduce a breaking change?

Not that I can think of

:memo: Links to relevant issues/docs

681

:thinking: Checklist before submitting

[x] All projects build
[ ] Follows style guide lines
[ ] Relevant documentation was updated
[ ] Rebased onto current develop

LuckyDucko commented 3 years ago

@IeuanWalker it seems to perhaps be something related to the navigation bar. I will give this some extra tweaking (surrounding navbar) but excellent stuff. PureWeen would be glad about using his stuff too.