Sample has many things disabled for setting up if the main package works.
removing legacy code
changing code to make better sense, in my opinion, however this may lead to more bugs.
:sparkles: What kind of change does this PR introduce? (Bug fix, feature, docs update...)
Added .net6 as target framwrork
Fix some non-breaking warnings and suggestions
Removed FxCopAnalyzers from MAUI projects since it's now included in the SDK itself
Set LangVersion to latest. There're only upsides in doing that
:arrow_heading_down: What is the current behavior?
:new: What is the new behavior (if this is a feature change)?
:boom: Does this PR introduce a breaking change?
No, but it changes public API a bit by adding nullable annotations (?) in few places
LuckyDucko
commented
2 years ago
Sample has many things disabled for setting up if the main package works. removing legacy code changing code to make better sense, in my opinion, however this may lead to more bugs.
:sparkles: What kind of change does this PR introduce? (Bug fix, feature, docs update...)
.net6as target framwrorkFxCopAnalyzersfrom MAUI projects since it's now included in the SDK itselfLangVersiontolatest. There're only upsides in doing that:arrow_heading_down: What is the current behavior?
:new: What is the new behavior (if this is a feature change)?
:boom: Does this PR introduce a breaking change?
No, but it changes public API a bit by adding nullable annotations (
?) in few places:bug: Recommendations for testing
:memo: Links to relevant issues/docs
684
:thinking: Checklist before submitting