search

rotorgames / Rg.Plugins.Popup

Xamarin Forms popup plugin
MIT License
1.15k stars 337 forks source link

Fix XamlParseException type converter #698

Closed yunusefendi52 closed 3 years ago

yunusefendi52 commented 3 years ago

:sparkles: What kind of change does this PR introduce? (Bug fix, feature, docs update...)

Bugfix

:arrow_heading_down: What is the current behavior?

Crashing XamlParseException

:new: What is the new behavior (if this is a feature change)?

This is not a feature change because user do not directly affected by this change, unless they are inheriting this type because maui uses System.ComponentModel.TypeConverter instead of creating their own type converter which Xamarin.Forms do right now

:boom: Does this PR introduce a breaking change?

No, unless they are inheriting this type

:bug: Recommendations for testing

Try changing DurationIn, DurationOut, EasingIn, EasingOut

:memo: Links to relevant issues/docs

https://github.com/rotorgames/Rg.Plugins.Popup/issues/684#issuecomment-930817567

:thinking: Checklist before submitting

LuckyDucko commented 3 years ago

Excellent, for some reason this seemed to not affect me, but I'm sure @maxkoshevoi will be pleased since i think it sorts his compile issue out.