rotorgames / Rg.Plugins.Popup

Xamarin Forms popup plugin
MIT License
1.15k stars 337 forks source link

Add back button handling in Sample #699

Closed maxkoshevoi closed 2 years ago

maxkoshevoi commented 2 years ago

Sample has many things disabled for setting up if the main package works. removing legacy code changing code to make better sense, in my opinion, however this may lead to more bugs.### :sparkles: What kind of change does this PR introduce? (Bug fix, feature, docs update...)

:arrow_heading_down: What is the current behavior?

Popups in Sample don't react on back button

:new: What is the new behavior (if this is a feature change)?

:boom: Does this PR introduce a breaking change?

No

:bug: Recommendations for testing

:memo: Links to relevant issues/docs

684

:thinking: Checklist before submitting

LuckyDucko commented 2 years ago

Init makes more sense in MainApplication for now, solely as its less to ask people to add in, as well as its not directly relevant to them.

We might push it back/add ome 'override' to MauiProgram later if people need it.