Fixed NaN issues with Android 9 and 10 when using multiple popups - Githubissues

rotorgames / Rg.Plugins.Popup

Xamarin Forms popup plugin

MIT License

1.15k stars 337 forks source link

Fixed NaN issues with Android 9 and 10 when using multiple popups #700

Closed zinvob closed 2 years ago

zinvob commented 2 years ago

:sparkles: What kind of change does this PR introduce? (Bug fix, feature, docs update...)

Bug fix

:arrow_heading_down: What is the current behavior?

Issues on Android 9 and 10 when starting multiple popups with animations

:new: What is the new behavior (if this is a feature change)?

Works properly on 8, 9, 10, 11 (tested)

:boom: Does this PR introduce a breaking change?

No

:bug: Recommendations for testing

Start multiple popups 2-4 and close them down fast.

:memo: Links to relevant issues/docs

:thinking: Checklist before submitting

[X] All projects build
[X] Follows style guide lines
[X] Relevant documentation was updated
[X] Rebased onto current develop

LuckyDucko commented 2 years ago

@martijn00 this request seems to work out fine within Maui where i've tested it there.

@zinvob could you do us a huge favor, in your recommendations for testing, you mention

Start multiple popups 2-4 and close them down fast.

Could you make a popup page that does this for testing reasons? there are several areas which could really benefit from this type of popup being available.

If you would rather just leave it at this change, just do the eyes react on this message. No hard feelings :)