Closed Axemasta closed 2 years ago
Implemented a fix for 721 which will no longer unhide invisible views if they are in the view hierarchy for screen readers
Bug fix for #721
See explanation in #721 for description and video, tl;dr: Android screenreader picks up elements that aren't visible after popup is closed
Fix popup close accessibility for TabbedPage layouts
TabbedPage
No
I have rebased by bug report branch with this & you can pull in the changes to demonstrate the fix.
There would need to be a test designed to pick this up in an app, like the repro I provided.
Implemented a fix for 721 which will no longer unhide invisible views if they are in the view hierarchy for screen readers
:sparkles: What kind of change does this PR introduce? (Bug fix, feature, docs update...)
Bug fix for #721
:arrow_heading_down: What is the current behavior?
See explanation in #721 for description and video, tl;dr: Android screenreader picks up elements that aren't visible after popup is closed
:new: What is the new behavior (if this is a feature change)?
Fix popup close accessibility for
TabbedPage
layouts:boom: Does this PR introduce a breaking change?
No
:bug: Recommendations for testing
I have rebased by bug report branch with this & you can pull in the changes to demonstrate the fix.
There would need to be a test designed to pick this up in an app, like the repro I provided.
:memo: Links to relevant issues/docs
721
:thinking: Checklist before submitting