search

rotundasoftware / backbone.collectionView

Easily render backbone.js collections. In addition to managing model views, this class supports automatic selection of models in response to clicks, reordering models via drag and drop, and more.
http://rotundasoftware.github.io/backbone.collectionView/
Other
171 stars 27 forks source link

Arrow key selection behavior change and tests #11

Closed colinwren closed 11 years ago

colinwren commented 11 years ago

Now If you are on the first list item and press the up arrow key, the selection will remain unchanged. The same is true for pressing the down arrow key on the last list item.

dgbeck commented 11 years ago

This looks good, but we can reuse currentOffset instead of calling this.getSelectedModel( { by : "offset" } ) multiple times. Also there is an extra space in the declaration of currentOffset

dgbeck commented 11 years ago

My bad, was looking at the old code! Will merge.