search

rotundasoftware / backbone.collectionView

Easily render backbone.js collections. In addition to managing model views, this class supports automatic selection of models in response to clicks, reordering models via drag and drop, and more.
http://rotundasoftware.github.io/backbone.collectionView/
Other
171 stars 27 forks source link

Bind all function names explicitly #27

Closed rbu closed 11 years ago

rbu commented 11 years ago

Fixes #26, Breaks with Underscore.js 1.5.0

go-oleg commented 11 years ago

@rbu ,

Thank you very much for taking the time to fix this. Please use the dev branch where the call to _.bindAll has been removed and we use .bind in the specific places that we need. The tests have been updated to use the latest underscore.js and are passing.

Going forward, please open pull requests against the dev branch.

Thanks again. We really appreciate it! -Oleg

rbu commented 11 years ago

Ah, thanks a lot for the pointer. I did not read the Contributing section of the readme. Is there a release of the dev branch upcoming? We currently use master+our patch, but we'd like to minimize deviation from upstream obviously.

rbu commented 11 years ago

Never mind, just saw this was merged to master.