rotundasoftware / backbone.collectionView

Easily render backbone.js collections. In addition to managing model views, this class supports automatic selection of models in response to clicks, reordering models via drag and drop, and more.
http://rotundasoftware.github.io/backbone.collectionView/
Other
171 stars 27 forks source link

Wrapper for CommonJS setup #48

Closed mulderp closed 10 years ago

mulderp commented 10 years ago

Hi,

just trying out the plugin in a CommonJS setup, but there seems to be a global Backbone reference needed to get the plugin running.

Would it be much effort to have a setup similar to: https://github.com/powmedia/backbone.xview/blob/master/xview.js#L18-L33 ?

Thanks!

dgbeck commented 10 years ago

k UMD wrapper just added (v0.9.2).Also collection view is now compatible with parcelify and cartero.. base styles from base.css should be included automatically with those build tools. Thanks!

mulderp commented 10 years ago

Hmm...

require('bb-collection-view')

returns an undefined if my observations are correct.

dgbeck commented 10 years ago

Hi @mulderp , looks like we forgot a return statement

https://github.com/rotundasoftware/backbone.collectionView/blob/master/src/backbone.collectionView.js#L1235

Can you check against master and confirm it is working as expected?

mulderp commented 10 years ago

thanks! that looks great!

On Wed, Apr 23, 2014 at 9:28 PM, David Beck notifications@github.comwrote:

Hi @mulderp https://github.com/mulderp , looks like we forgot a return statement

https://github.com/rotundasoftware/backbone.collectionView/blob/master/src/backbone.collectionView.js#L1235

Can you check against master and confirm it is working as expected?

— Reply to this email directly or view it on GitHubhttps://github.com/rotundasoftware/backbone.collectionView/issues/48#issuecomment-41203910 .

mulderp commented 10 years ago

hey @dgbeck - just pushed a small demo repo here: https://github.com/mulderp/backbone-collectionview

would need to add some basic styling to make it nice - but the main point, the npm/browserify setup is working

dgbeck commented 10 years ago

Awesome.. thanks!