search

rotundasoftware / cartero

Modular front end development for multi-page web applications.
MIT License
204 stars 25 forks source link

Fix error propagation when browseify fails #42

Closed ferlores closed 9 years ago

ferlores commented 9 years ago

@dgbeck I'm having a problem when browserify fails. The error is not being propagating and therefore my build process is not failing even if there is an error. It looks like a logic change what I'm proposing but I'm not super sure about re-emiting the error in watch mode. Opinions?

Thanks F

dgbeck commented 9 years ago

Yes I'm pretty sure we are not re-emitting the error so that we don't die on watch mode, if somebody saves an invalid js file or something. I think this one would be ok though

https://github.com/ferlores/cartero/blob/master/index.js#L365

Is that one enough to fail the process properly?

ferlores commented 9 years ago

Yes, for my use case I don't need to emit the error in watch mode. I've updated the PR, please check. Thanks!

ferlores commented 9 years ago

Thanks for merging. Can you please let me know when you are publishing this patch?

dgbeck commented 9 years ago

Published in v5.2.1. Thx!