search

rotundasoftware / nunjucksify

Everything you expect from a module named nunjucksify and more.
34 stars 10 forks source link

Move runtime shim to dedicated file #14

Closed niksy closed 8 years ago

niksy commented 8 years ago

It takes the same approach as nunjucks-loader for Webpack - separates runtime shim to dedicated file.

Benefits:

  1. Easier editing.
  2. Dedicated module which can be extracted to common bundle and be required and referenced just once, making required files really small if you have large set of templates.

The tests aren’t passing, but they don’t pass even without these changes, do you know what can be the problem?

dgbeck commented 8 years ago

This looks good to me! We are going to try it out this / next week and also look into why the tests are failing, will merge shortly thereafter. Thx!