search

rotundasoftware / parcelify

Add css to your npm modules consumed with browserify.
MIT License
251 stars 20 forks source link

Why have an array for the styles property? #3

Closed techwraith closed 10 years ago

techwraith commented 10 years ago

Quite a few modules are standardizing on the style: 'index.css' style of css definition. If you moved to that style you'd be compatible with modules built for:

Would you consider changing it?

dgbeck commented 10 years ago

Hi @Techwraith! What if we were to default to index.css, as described in #2?

jaredly commented 10 years ago

I don't imagine it would be difficult to allow either a string or a list of strings...

dgbeck commented 10 years ago

Ah, maybe I misunderstood the question.. a single string is already supported. From the docs,

The style key is a glob or array of globs that describe the style assets of the module.

techwraith commented 10 years ago

As long as it works with "style.css", "mymodule.css", or "index.css" I'm good. I just think it'll suck if we have multiple different types of front end modules getting developed that aren't compatible across the whole range of tools. I don't often support standards, but this is one that I feel strongly about.

On Fri, Mar 14, 2014 at 10:42 AM, David Beck notifications@github.comwrote:

Ah, maybe I misunderstood the question.. a single string is already supported. From the docs,

The style key is a glob or array of globs that describe the style assets of the module.

Reply to this email directly or view it on GitHubhttps://github.com/rotundasoftware/parcelify/issues/3#issuecomment-37675557 .

dgbeck commented 10 years ago

k looks like we are good then. thx for feedback