Fix/226 julia manual download

roualdes / bridgestan

BridgeStan provides efficient in-memory access through Python, Julia, and R to the methods of a Stan model.

https://roualdes.github.io/bridgestan

BSD 3-Clause "New" or "Revised" License

88 stars 12 forks source link

Fix/226 julia manual download #227

Closed WardBrian closed 5 months ago

WardBrian commented 5 months ago

This closes #226 and brings the Julia interface in line with the others by storing the bridgestan sources in ~/.bridgestan

A couple things worth noting:

Julia's expanduser function does nothing on Windows. I've added a helper function to get the home directory based on what Python does
This adds a few "dependencies": Tar, TOML, Downloads, and Inflate. I use the scare quotes because all except for Inflate are built in to Julia. Inflate, meanwhile, is used in examples in Julia's documentation, and seems very stable.

WardBrian commented 5 months ago

Ok, so Julia's Tar library didn't support hardlinks until Julia 1.7: https://github.com/JuliaIO/Tar.jl/pull/102

I've updated the release action to generate tarballs without them (it's just a single extra copy of bridgestan.h), but in the mean time the Julia 1.6 test will stay failing. Not really sure what to do

WardBrian commented 5 months ago

I confirmed that adding --hard-dereference to our packaging step produces a tarball which julia 1.6 can read.

So, we can either:

merge this while it is failing, knowing the next release will actually be fine
merge just the release.yml change to add that flag, make a small release, and then merge the Julia changes