roubachof / Sharpnado.MaterialFrame

A modern MAUI (and XF) Frame component supporting blur, acrylic, dark mode. Implemented with RealtimeBlurView on Android (custom blurview) and UIVisualEffectView on iOS.
MIT License
498 stars 26 forks source link

Add an XMLNS Definition #11

Closed dansiegel closed 3 years ago

dansiegel commented 4 years ago

Is your feature request related to a problem? Please describe.

Particularly as there is more than one Sharpnado package, any UI elements that would be referenced from XAML should be easily available with a single xmlns.

Describe the solution you'd like

<ContentPage xmlns:sharpnado="http://sharpnado.com">
  <sharpnado:MaterialFrame />
</ContentPage>

Describe alternatives you've considered

n/a

Additional context

Add a XmlnsDefinitionAttribute to all Sharpnado packages like:

[assembly: Xamarin.Forms.XmlnsDefinition("http://sharpnado.com", "Sharpnado.MaterialFrame")]
[assembly: Xamarin.Forms.XmlnsDefinition("http://sharpnado.com", "Sharpnado.AnotherClrNamespace")]

This helps to keep XAML cleaner particularly as you use an aggregate of types across your project as you do not have to remember which assembly something was in or what the clr namespace is.

roubachof commented 3 years ago

fixed by https://github.com/roubachof/Sharpnado.MaterialFrame/releases/tag/v1.1.3

dansiegel commented 3 years ago

great to see!