roubachof / Sharpnado.MaterialFrame

A modern MAUI (and XF) Frame component supporting blur, acrylic, dark mode. Implemented with RealtimeBlurView on Android (custom blurview) and UIVisualEffectView on iOS.
MIT License
505 stars 29 forks source link

MAUi support ? #25

Closed sps014 closed 10 months ago

sps014 commented 2 years ago

Is there any plan to port this awesome control to dotnet MAUI?

roubachof commented 2 years ago

Yup all sharpnado controls will be migrated to MAUI

sps014 commented 2 years ago

Thank you for doing such wonderful task.

lkathke commented 2 years ago

Are they already migrated? If yes, how to use it?

lkathke commented 2 years ago

Still no update? :\

roubachof commented 2 years ago

It will be considered once maui is a bit stable. For now it would just be a waste of time.

shrikantbmali commented 2 years ago

any update?

mphill commented 2 years ago

@roubachof could not agree more! They locked down Xamarin, but MAUI is not useable. Happy you're going to port to MAUI nonetheless!

roubachof commented 2 years ago

Hey there ! I'm curious since now you can have good configuration on MAUI like borders, shadows, etc... Why would you want to have this library ported to MAUI, I'm struggling to see the point...

grumpymonk commented 2 years ago

Hey there ! I'm curious since now you can have good configuration on MAUI like borders, shadows, etc... Why would you want to have this library ported to MAUI, I'm struggling to see the point...

I have not yet been able to find a baked-in "MAUI way" for the blur effect (specifically for Android) that MaterialFrame provides. Personally, I would love to see this ported, as it's also very cohesive in terms of the package of features.

RobGibbens commented 2 years ago

Hey there ! I'm curious since now you can have good configuration on MAUI like borders, shadows, etc... Why would you want to have this library ported to MAUI, I'm struggling to see the point...

@roubachof I have a fairly large Xamarin.Forms app that I want to bring over to MAUI. It uses MaterialFrame extensively, and I want to port the app over in small increments. Having a MAUI version of MaterialFrame would be a huge help in that, so that I could focus on migrating more than rewriting.

Thanks for all you do and all that you've provided.

danperks commented 1 year ago

Would love to use this if ported over to MAUI!

roubachof commented 1 year ago

oh boy, so much people waiting for this one... I guess, will have to port it

aritchie commented 1 year ago

I think the fact that you have the view blur is a big deal (at least for me). I just went looking for a blur implementation and as usual, your stuff came up :)

enisn commented 1 year ago

I came here from https://github.com/dotnet/maui/issues/705

I know it's not the exact thing but I've implemented something similar

Strypper commented 1 year ago

Hey there ! I'm curious since now you can have good configuration on MAUI like borders, shadows, etc... Why would you want to have this library ported to MAUI, I'm struggling to see the point...

It doesn't do blur

roubachof commented 1 year ago

FYI I started working on the MAUI migration

roubachof commented 1 year ago

Oh and @enisn not cool to just copy paste all my adaptation of RealtimeBlurView in csharp and not mentioning it anywhere...

enisn commented 1 year ago

Oh and @enisn not cool to just copy paste all my adaptation of RealtimeBlurView in csharp and not mentioning it anywhere...

I think you ported from https://github.com/mmin18/RealtimeBlurView too

roubachof commented 1 year ago

This is why there is this header on the top of every realtime blur view files, you know, the one you carefully removed:

//------------------------------------------------------------------------------
//
// https://github.com/mmin18/RealtimeBlurView
// Latest commit    82df352     on 24 May 2019
//
// Copyright 2016 Tu Yimin (http://github.com/mmin18)
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
//
//------------------------------------------------------------------------------
// Adapted to csharp and Xamarin.Forms by Jean-Marie Alfonsi
//------------------------------------------------------------------------------
// <auto-generated/>

and also this mention in the readme:

image

and in the description:

image

It took me days to port the lib and you just have the nerves to steal the code and of top of that to come into this issue to brag about it: you're my hero.

Strypper commented 1 year ago

So apache license is free to steal but have to mention somewhere or someway ?

roubachof commented 1 year ago

He indeed violated Apache license but more importantly he violated dev ethics, you don't take code without crediting the source. Especially if it's nearly 1000 lines of code.

meierhoeferjannis commented 1 year ago

Hey i saw there is a branch for the migration to Maui :D Do you have a raw estimate when it will be merged to main and released:)? Thanks for all the effort and providing such a great library !

ChristopherStephan commented 1 year ago

Any updates on the migration?

roubachof commented 1 year ago

Funny thing: it was nearly working on all platforms then a maui update and nice regression made winUI version crashed. CLASSIC

ChristopherStephan commented 1 year ago

Who needs winUI anyway? :-D

roubachof commented 1 year ago

xo) Well I guess I could release it with the WinUI crash and shame MS publicly

roubachof commented 11 months ago

Ok bugs or not, I promise that I will release it in january 2024.

roubachof commented 10 months ago

fixed by https://github.com/roubachof/Sharpnado.MaterialFrame/releases/tag/v2.0