Closed jbachelor closed 4 years ago
Here is a quick video demonstrating the issue - Watch the debug output in Visual Studio as I tap the center tab button vs. tapping on the background area. Background area taps are handled by the TapGestureRecognizer (debug output from the code-behind of SillyBottomTabsPage.xaml), and taps on the button itself are handled by the command wired up to the ViewModel (SillyBottomTabsPageViewModel.cs).
https://drive.google.com/open?id=1XGIBPTiaEnsJIT8ckdp66M35lqccAMAz
Here is the version of the "SillyCompany.Mobile.Practices" app used to take the video from my previous comment. Please do not hesitate to let me know if you have any questions at all.
https://drive.google.com/open?id=1Re1P_5zx55W-1DElQykL-94qbv55RL1G
Thank you again for your hard work on Sharpnado!
Thank you for the extensive informations, I will fix this in the next release.
Thank you so much... If I can be of any assistance, please let me know!
A clicked event will be added in version 1.4.
Platform (please complete the following information):
OS: [iOS/Android/Both] Both iOS and Android, physical devices or simulator/emulator.
Device: [iPhone6/iPhoneSimulator/Pixel/AndroidEmulator/...] Tested on physical iPhone X running iOS 13.2 Tested on multiple iOS simulators running iOS 13.2 and 12.2 Tested on physical LG V20 running Android 8.0.0 (api 26) Tested on Android emulator running Android 8.1.0 (api 27) Tested on Android emulator running Android 9.0 (api 28)
Sdk vervion: [iOS 11/Android SDK 21] SDK versions listed above, along with each device.
Xamarin.Forms: [3.4.0.1029999] Using the SillyCompany.Mobile.Practices sample app, which currently is on XF 4.2.0.815419. Also tested upgrading to the latest Xamarin.Forms (currently 4.3.0.947036), and the behavior was the same.
Describe the bug First, thank you so much for this awesome library, sample code, and super helpful blog posts. Sharpnado is allowing me to create the exact look and feel I was hoping for!
It appears there is no 'Clicked' event on the TabButton, and I wanted to run a small animation when the button was tapped. I added a TapGestureRecognizer to the TabButton, and tried to animate the button when tapped. However, the button itself does not seem to register the taps... Only the area of the TabButton that is not the button, but rather the background, responds to taps.
I also wired up the TapCommand to an ICommand in my view model, and it responds to taps of the button area itself, but not the background, which is perfect. I would have expected the TapGestureRecognizer to cover the whole control.
To Reproduce Steps to reproduce the behavior:
NOTE: Screenshots of code changes made provided below.
Exceptions (if applicable) N/A
Screenshots (if applicable)