Open ryan-di opened 2 years ago
Given that the AnnotationState is
AnnotationState
type AnnotationState = 'unattached' | 'not-showing' | 'showing';
and when we call the private attach() method, we first check if the state is 'unattached'
attach()
'unattached'
private attach() { if (this._state === 'unattached' && this._e.parentElement) { // ... } }
I think the this.attach() statement in the 'not-showing' case is redundant.
this.attach()
'not-showing'
show(): void { switch (this._state) { case 'unattached': // ... case 'showing': // ... case 'not-showing': this.attach(); if (this._svg) { this.render(this._svg, false); } break; } }
Not sure if I'm missing anything : )
You're probably right. It's redundant but benign as well. I'll have to think of why this was added. Wish I had commented the code :)
Given that the
AnnotationState
isand when we call the private
attach()
method, we first check if the state is'unattached'
I think the
this.attach()
statement in the'not-showing'
case is redundant.Not sure if I'm missing anything : )