Setting stroke to "none" has no effect on canvas

rough-stuff / rough

Create graphics with a hand-drawn, sketchy, appearance

http://roughjs.com

MIT License

19.73k stars 611 forks source link

Setting stroke to "none" has no effect on canvas #177

Closed jwoLondon closed 3 years ago

jwoLondon commented 3 years ago

Is there a way to stop outer stroke drawing on canvas? Setting stroke:"none" works for SVG but not for canvas. I realise one can set stroke: "rgba(0,0,0,0)", but would be good to have a more performant approach and one that is consistent between SVG and Canvas contexts.

pshihn commented 3 years ago

If it doesn't do that on canvas, then it's definitely a bug. Let me take a look.

jwoLondon commented 3 years ago

Here's a minimal reproducible example via Observable:

https://observablehq.com/d/e7de66607b365674

pshihn commented 3 years ago

Ahh it got fixed in v4.0 Your example uses 3.0 Here's a fork with the latest version: https://observablehq.com/@preetster/rough-strokes

jwoLondon commented 3 years ago

Ah, thanks. I didn't realise there was a V4. Sorry for wasting your time.

pshihn commented 3 years ago

no problem at all!