search

rough-stuff / rough

Create graphics with a hand-drawn, sketchy, appearance
http://roughjs.com
MIT License
19.73k stars 611 forks source link

0-roughness ellipse not closed in specific cases #197

Closed dwelle closed 2 years ago

dwelle commented 2 years ago

image

https://excalidraw.com/#json=R1JU7RsS5B7Pdo9ZdyS0S,_KvML889O3uvvh-NpJV7KQ

I believe it's related to https://github.com/rough-stuff/rough/pull/189, because it started happening on excalidraw after we landed the fix.

You can copy/paste the ellipse into these previews:

The commit it starts to first reproduce on: https://excalidraw-8tfjr1cim-excalidraw.vercel.app/ (https://github.com/excalidraw/excalidraw/pull/4194) Commit before: https://excalidraw-8d0rzxm4n-excalidraw.vercel.app/ (doesn't reproduce)

Reproduces across browsers (Chrome 96, FF, Safari).

pshihn commented 2 years ago

This is weird. I see the issue in the link you share but every new ellipse I draw, it draws properly. There's definitely a bug. I'll check it out.

pshihn commented 2 years ago

fix released in v4.5.1

dwelle commented 2 years ago

Thanks for the quick fix! ❤️