Non-highlighted title text is cut off

roughike / BottomBar

(Deprecated) A custom view component that mimics the new Material Design Bottom Navigation pattern.

Apache License 2.0

8.41k stars 1.5k forks source link

Non-highlighted title text is cut off #436

Closed kevinschlieper closed 7 years ago

kevinschlieper commented 8 years ago

Hi,

I have noticed that the bottom part of the title text is cut off. However, for some reason that doesn't seem to be a problem for the first tab, but only for the 2nd and 3rd (only tested with 3 tabs). You can see the problem in the sample app as well.

Steps to reproduce:

Start BottomBar sample app.
Choose "SIMPLE EXAMPLE WITH THREE TABS"
Observe the 2nd tab

Actual behavior: The "y" is cut off (but only in the non-highlighted state).

Expected behavior: Text shouldn't be cut off.

bottombar text cut off

Let me know if you need more input.

Kevin

smoothdvd commented 8 years ago

I have same bug, and the cut off value is random.

flukeylukey commented 8 years ago

Hi, I'm having the same bug too. I have 4 tabs. The 3rd tab title is "History", and 'y' is cut off when non-highlighted.

MilesGoon commented 8 years ago

oooooh, My title was hidden too :(

roughike commented 8 years ago

It was related to the updateTitlePadding() method that was merged from someone else's PR.

The fix will be released with the version 2.0.3.

smoothdvd commented 8 years ago

@roughike Thanks

Ovadia-B commented 8 years ago

I fixed it with this style: `

yuriChechetkin commented 8 years ago

@Ovadia-B where should i apply this style? for me it doesn't work :(

rudakovsky commented 8 years ago

I am facing the same problem but only after I call DialogFragement from Fragment on a tab

Ovadia-B commented 8 years ago

@yuriChechetkin Just copy & paste those lines in your styles.xml file, it will override the style from the library.

tomaszczura commented 8 years ago

Same for me, but applying style doesn't work. When do you plan to release 2.0.3 version?

daveak01 commented 8 years ago

Will keep an eye on this thread and await 2.0.3 for a permanent fix however for the interim, @Ovadia-B your fix did the trick for me for now! thanks very much!

Great work @roughike, keep it up!!

mkmckenna commented 8 years ago

@Ovadia-B Thanks, that worked for me.

dmitriialeksandrov commented 8 years ago

For guys who have issues with temporary workaround by @Ovadia-B, you can also add android:includeFontPadding with false value into the style above, it did the trick for me.

Ovadia-B commented 7 years ago

Google released new API in support library v25 with BottomNavigationView.

New APIs

android.support.design.widget.BottomNavigationView class implements the bottom navigation pattern from the Material Design spec.

huttarl commented 7 years ago

Thanks @dmitriialeksandrov, that helped -- it reduced the amount of text cut off, but didn't get rid of it completely. It also turned out that my icons were not 24dp. Once I fixed that, the text was no longer cut off!