search

roughike / BottomBar

(Deprecated) A custom view component that mimics the new Material Design Bottom Navigation pattern.
Apache License 2.0
8.42k stars 1.5k forks source link

Changing icons based on selection state invalidation to bottom-bar:2.3.1 #756

Open pangli opened 7 years ago

pangli commented 7 years ago

I want to effect: image res: image

My code: image image

displaying results: image

I don't know where to write has a problem, give advice or comments please

yombunker commented 7 years ago

@pangli sorry for the confusion here, the thing is that currently we always apply a tint to your drawable, what the selector allows you to do, is change wich drawable will get tinted. In the next release we will add the ability to not have the tint added automatically, if you don't set a tint, currently we default to some color even if you haven't selected one :(

pangli commented 7 years ago

Ok, thank you!

stormlei commented 7 years ago

@yombunker I also encountered the same problem, when to update, very anxious.

yombunker commented 7 years ago

@stormlei still no ETA on the next update, i'm a little busy with my day job that i haven't been able to finish the changes. I'm like 60% done.

imxy commented 7 years ago

@yombunker can u tell us about the progress of this changes? cause its been a long time from your last relase... its a kind of emergency for me...

yombunker commented 7 years ago

@imxy to be honest, i already re-wrote the library, and has a very good amount of interop code with this version (sample app had only minor changes to make it work, because now it uses Generics to allow customization), but, we haven't decided in my team (work) if we want to go through the hassle of updating it here or not, because in here we depend on @roughike to do releases or what not, i'll be out for the weekend for droidcon san francisco, but, when i come back i'll talk to my boss and PMs about it. and if they decide we are going to contribute to the library i'll send a big PR here that pretty much just re-writes the whole library while trying to maintain it compatible. The things that don't work are if you were getting direct access to the views and modifying them, cause now they are just interfaces not really views.